Automatically identifies the class name based on the specified line number. #2280
+26
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splines
reviewed
Dec 17, 2024
|
|
||
| # Add the relevant embed line to the code | ||
| indent = get_indent(lines, line_number) | ||
| lines.insert(line_number, indent + "self.embed()") | ||
| new_code = "\n".join(lines) | ||
|
|
||
| # When the user executes the `-e <line_number>` command, | ||
| # it should automatically identifies the nearest class |
There was a problem hiding this comment.
Suggested change
| # it should automatically identifies the nearest class | |
| # it should automatically identify the nearest class |
| @@ -5,13 +5,13 @@ | |||
| # you are running manim. For 3blue1brown, for instance, mind is | |||
| # here: https://github.com/3b1b/videos/blob/master/custom_config.yml | |||
|
|
|||
| # Alternatively, you can create it whereever you like, and on running | |||
| # Alternatively, you can create it where ever you like, and on running | |||
There was a problem hiding this comment.
Suggested change
| # Alternatively, you can create it where ever you like, and on running | |
| # Alternatively, you can create it wherever you like, and on running |
| # When the user executes the `-e <line_number>` command, | ||
| # it should automatically identifies the nearest class | ||
| # defined above `<line_number>` as 'scene_names'. | ||
| classes = list(filter(lambda line: line.startswith("class"), lines[:line_number])) |
There was a problem hiding this comment.
What about classes that are defined as nested class, i.e. inside some other classes? They would have an indentation so line.startswith("class") would return False.
There was a problem hiding this comment.
I guess the Scene Class (like: class SomeName(Scene)) would not be the nested one. So, I think in that case as well, it works.
Splines
reviewed
Dec 17, 2024
| @@ -142,35 +143,48 @@ def get_indent(code_lines: list[str], line_number: int) -> str: | |||
| return n_spaces * " " | |||
|
|
|||
|
|
|||
| def insert_embed_line_to_module(module: Module, line_number: int): | |||
| def insert_embed_line_to_module(module: Module, run_config: Dict) -> None: | |||
There was a problem hiding this comment.
Instead of passing run_config inside here, an alternative could be to return the scene names from this function and then update the scene_names of run_config from somewhere outside, e.g. in get_module that is calling insert_embed_line_to_module).
Alexizx00789999
approved these changes
Dec 24, 2024
Alexizx00789999
approved these changes
Dec 24, 2024
Alexizx00789999
approved these changes
Dec 24, 2024
Alexizx00789999
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Whenever some user passes the command
-e <line_number>, it feels redundant to specify the class name.The closest class name (above the specified
<line_number>) should automatically be identified by the program, and updates the value ofscene_nameskey in therun_configdict.Proposed Changes
I couldn't find a better position to insert the code than in the
insert_embed_line_to_modulefunction. As it ensures that thescene_namesupdates only when theeflag is passed, and also the module lines can be used to determine the class name.Also, resolving minor bugs in
text_mobjectandstring_mobjectfiles.